Repository navigation
Add personal card - "Something not working?" modal appears briefly, then disappears - #87072
Conversation
|
@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9c772bb018
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
Hello! I will take over this PR from @narefyev91. Please ping me if any further FE change will be necessary. |
|
🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-04-04.at.12.58.39.AM.movAndroid: mWeb ChromeScreen.Recording.2026-04-04.at.1.03.47.AM.moviOS: HybridAppScreen.Recording.2026-04-04.at.12.42.49.AM.moviOS: mWeb SafariScreen.Recording.2026-04-04.at.12.52.35.AM.movMacOS: Chrome / SafariScreen.Recording.2026-04-03.at.11.43.54.PM.mov |
|
Do we have to show the loading circle in the RHP after backing out of Plaid? Showing the country list there before you make a selection on the "report error" modal looks way better IMO 2026-04-03_14-41-30.mp4 |
|
@joekaufmanexpensify The loader shows because plaidData.isLoading is never reset to false (isLoading stays true unless the server response explicitly clears it). The fix keeps the user on the PLAID_CONNECTION until the modal is closed, so that's why we still see the modal I am testing a change that might fix the issue, if it's not ideal we need to decide if we're keeping the current fix or I should look for another solution. The root cause of the original issue is for sure that the selector's input is focused when the modal appears, so it opens the keyboard on iOS, resulting in dismissing the modal. |
|
@joekaufmanexpensify the change I was testing is not working - the problem with the keyboard still exists. Do you want me to work on a different solution for this issue to prevent showing the loader or are we going with the solution that is already implemented here (and ignore the loader)? |
|
Let's align in the slack thread. |
|
@joekaufmanexpensify done Screen.Recording.2026-04-08.at.14.51.05.mp4I'm having problems with testing on web and android - on web Plaid is not opening and on the android is crashing. It's not because of my changes. After merging with main mobile is crashing because of this https://expensify.slack.com/archives/C01GTK53T8Q/p1775647713207879 - so not merging with main @ShridharGoel could you please review once again? |
|
🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Nice, web experience now matches what I'd expect 👍 2026-04-08_12-38-14.mp4 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 @amyevans has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.55-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes are required for this PR. The changes here are a UI bug fix (preventing keyboard auto-focus from dismissing the "Something not working?" modal during the Add personal card flow). No new features, settings, workflows, or terminology were introduced — nothing in |
|
@narefyev91 This PR is failing because of a regression issue #87445 The issue is reproducible in: Web Bug7125391_1775697830940.Recording__1976.mp4 |
|
@mitarachim could you try testing again? We've resolved the regression noted in #87445 |
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.57-0 🚀
Bundle Size Analysis (Sentry): |
|
No help site changes required. This PR is a UI bug fix that prevents the keyboard from auto-focusing and causing the "Something not working?" modal to briefly appear then disappear when exiting the Plaid flow during personal card setup. The changes are limited to:
There are no new features, renamed settings, changed workflows, or terminology updates that would affect any help site documentation under |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.57-1 🚀
|
|
Sorry for late response @amyevans , QA team confirm issue is not reproducible using latest build v9.3.58-0 Recording.1990.mp4 |
Explanation of Change
"Something not working?" modal appears briefly, then it disappears, and the keyboard opens
Fixed Issues
$ #86600
PROPOSAL:
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
iOS: Native
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov